Skip to content

Commit

Permalink
Install git before actions/checkout
Browse files Browse the repository at this point in the history
This fixes the workflow failing at "Build and install JAX" step as it wasn't able to run git command to fetch the `jaxlib` git hash

Without git present on the PATH, it seems that `actions/checkout` (see its logs) will download the code with the GitHub REST API. This means that the code is not a git repository and therefore any subsequent git commands will fail.

PiperOrigin-RevId: 700336969
  • Loading branch information
nitins17 authored and Google-ML-Automation committed Nov 26, 2024
1 parent 9c42379 commit 97d80ee
Showing 1 changed file with 11 additions and 9 deletions.
20 changes: 11 additions & 9 deletions .github/workflows/asan.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,17 @@ jobs:
run:
shell: bash -l {0}
steps:
- name: Install clang 18
env:
DEBIAN_FRONTEND: noninteractive
run: |
# Install git before actions/checkout as otherwise it will download the code
# with the GitHub REST API and therefore any subsequent git commands will fail.
apt update
apt install -y clang-18 libstdc++-14-dev build-essential libssl-dev \
zlib1g-dev libbz2-dev libreadline-dev libsqlite3-dev curl git \
libncursesw5-dev xz-utils tk-dev libxml2-dev libxmlsec1-dev \
libffi-dev liblzma-dev
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
path: jax
Expand All @@ -33,15 +44,6 @@ jobs:
repository: python/cpython
path: cpython
ref: v3.13.0
- name: Install clang 18
env:
DEBIAN_FRONTEND: noninteractive
run: |
apt update
apt install -y clang-18 libstdc++-14-dev build-essential libssl-dev \
zlib1g-dev libbz2-dev libreadline-dev libsqlite3-dev curl git \
libncursesw5-dev xz-utils tk-dev libxml2-dev libxmlsec1-dev \
libffi-dev liblzma-dev
- name: Build CPython with ASAN enabled
env:
ASAN_OPTIONS: detect_leaks=0
Expand Down

0 comments on commit 97d80ee

Please sign in to comment.