Add test case for jit compile of vmap on gpu #25980
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakevdp
requested changes
Jan 20, 2025
tests/jax_jit_test.py
Outdated
Comment on lines
209
to
210
| if jtu.device_under_test() == "cpu": | ||
| self.skipTest("Test only runs on GPU") |
There was a problem hiding this comment.
Remove the skip? no harm in running this test on CPU as well.
There was a problem hiding this comment.
Sounds good. The initial thought is to emphasize the issue on GPU. But I'm ok to allow tests on other device types as well.
tests/jax_jit_test.py
Outdated
| pos = H @ jnp.concatenate([x, jnp.array([1.0])]) | ||
| return pos, R1 | ||
| jitted_fn = jax.jit(fn) | ||
| x_gpu = jax.device_put(jnp.zeros((2,3)), jax.local_devices()[0]) |
There was a problem hiding this comment.
No need for explicit device put I think: when the tests are run on GPU, the default device is GPU.
tests/jax_jit_test.py
Outdated
| return pos, R1 | ||
| jitted_fn = jax.jit(fn) | ||
| x_gpu = jax.device_put(jnp.zeros((2,3)), jax.local_devices()[0]) | ||
| jitted_fn(x_gpu) |
There was a problem hiding this comment.
It wouldn't hurt to also validate the expected output.
There was a problem hiding this comment.
Ok. My style is a little focus on the specific GPU issue. While the suggestion sounds good for the test itself.
Co-authored-by: Jake Vanderplas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The error case of jit compile of vmap on GPU is reported in openxla/xla#15744. @jakevdp
I fetched the head of jax repository. Build and installed jax from source. Modified the code to use jax.device_put and jax.local_devices which is required for the new jax version. The test passed.
System Configurations
GPU: NVIDIA T4
Google cloud machine type: n1-standard-4
Linux x86-64