Clarify type hints for wrapped functions #25994
Conversation
Wrapped functions preserve the call signature of the original function, but do NOT preserve other aspects of the input type (such as additional attributes and methods). Avoids type checking failures from an upcoming `typeshed` update which fixes this same discrepancy in the signature of `ContextDecorator.__call__`.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
This PR is a follow up to this PR on typeshed that fixed the nominal signature of One of the |
| @@ -3051,7 +3051,7 @@ def _cond( | |||
| index: TfVal, *operands: TfVal, branches: Sequence[core.ClosedJaxpr] | |||
| ) -> Sequence[TfVal]: | |||
| # tf.cond needs lambdas with no arguments. | |||
| branches_tf = [ | |||
| branches_tf: list[Callable[[], Any]] = [ | |||
There was a problem hiding this comment.
An alternative fix here would be to use two different local variable names, but the type declaration also statically enforces the expected outcome of the list comprehension.
Wrapped functions preserve the call signature of the
original function, but do NOT preserve other aspects
of the input type (such as additional attributes and
methods).
Avoids type checking failures from an upcoming
typeshedupdate which fixes this same discrepancyin the signature of
ContextDecorator.__call__.