CI: don't share cache between C compilers #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Cache cabal files"-step would restore a cache from a key that does not include the C compiler, which means e.g. Clang could restore stuff built by GCC. Also, the `restore-keys` key didn't even include the GHC version. This meant that -- in case of a cache miss for `key` -- a cache built by one GHC version could be pulled for a CI run for another GHC version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Cache cabal files"-step would restore a cache from a key that does not include the C compiler, which means a job using e.g. Clang as the C compiler could restore stuff built using GCC.
Also, the
restore-keyskey didn't even include the GHC version. This meant that -- in case of a cache miss forkey-- a cache built by one GHC version could be pulled for a CI run for another GHC version.