added bbox_inches flag. Defaults to None #95
Conversation
| @@ -274,6 +276,9 @@ def __init__( | |||
| Movie size. | |||
| dpi : int | |||
| Movie resolution. | |||
| bbox_inches: str | |||
| Same as bbox_inches flag in savefig from matplotlib. | |||
There was a problem hiding this comment.
| Same as bbox_inches flag in savefig from matplotlib. | |
| Passed to :meth:`~matplotlib.figure.Figure.savefig` when saving frames. |
| @@ -274,6 +276,9 @@ def __init__( | |||
| Movie size. | |||
| dpi : int | |||
| Movie resolution. | |||
| bbox_inches: str | |||
There was a problem hiding this comment.
| bbox_inches: str | |
| bbox_inches: str or matplotlib.transforms.Bbox |
| @@ -274,6 +276,9 @@ def __init__( | |||
| Movie size. | |||
| dpi : int | |||
| Movie resolution. | |||
| bbox_inches: str | |||
| Same as bbox_inches flag in savefig from matplotlib. | |||
| Bounding box in inches: only the given portion of the figure is saved. If 'tight', try to figure out the tight bbox of the figure. | |||
There was a problem hiding this comment.
| Bounding box in inches: only the given portion of the figure is saved. If 'tight', try to figure out the tight bbox of the figure. | |
| Bounding box in inches: only the given portion of the figure is saved. | |
| If ``'tight'``, try to figure out the tight bbox of the figure. | |
| Try this option to eliminate unnecessary amounts of edge whitespace in frames. |
There was a problem hiding this comment.
Should pad_inches also be added?
| @@ -253,6 +254,7 @@ def __init__( | |||
| pixelwidth=1920, | |||
| pixelheight=1080, | |||
| dpi=200, | |||
| bbox_inches=None, | |||
There was a problem hiding this comment.
We might add other kwargs for .savefig() here (see comments below). If so should we have some dict that catches all save_kwargs=None (we can then set defaults we like in the init)? Otherwise we might be accumulating a bunch of input arguments and the signature of this might become unruly?
| @@ -285,6 +290,7 @@ def __init__( | |||
| self.pixelwidth = pixelwidth | |||
| self.pixelheight = pixelheight | |||
| self.dpi = dpi | |||
| self.bbox_inches = bbox_inches | |||
There was a problem hiding this comment.
Same here. I would prefer to carry self.save_kwargs here as a dict.
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
+ Coverage 77.53% 78.59% +1.05%
==========================================
Files 3 3
Lines 325 327 +2
Branches 61 61
==========================================
+ Hits 252 257 +5
+ Misses 48 46 -2
+ Partials 25 24 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Related to #94
This may help users with eliminating whitespace and other alignment related issues.