-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SQL #76
base: master
Are you sure you want to change the base?
Fix SQL #76
Conversation
@diorcety Thanks, someone will review your pull request soon |
@yegor256 review this pls (it's a rather short pull request) |
@rultor try to merge pls |
@diorcety @yegor256 Oops, I failed. You can see the full log here (spent 10min)
|
@diorcety the merge failed because your branch breaks our static analysis rules. Can you please run |
Hi, i looked the issue. It seems to be a false positive |
@diorcety this is a valid problem:
Has to be fixed before the branch can be merged. Can you please fix this? |
Looks like a false positive. I didn't use ternary operator |
@diorcety I understand that it's a bit too late (8 years :), but still, maybe you want to fix this PR to make sure it doesn't have conflicts, and I will merge |
If the config asks for test database name, there is a conflict with the default test database.