Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing CLASSPATH from the environment when launching lein #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

quoll
Copy link

@quoll quoll commented Feb 23, 2021

Addresses #46

This does not have tests associated with it, since it's a bit of a mess when running with leiningen 2.9.5.

I do have a simple module that no longer gives the CLASSPATH warning, and can work on automating the test if you want.

@jcrossley3
Copy link
Owner

Thanks! Can you elaborate on the "bit of a mess" please?

@quoll
Copy link
Author

quoll commented Feb 24, 2021

Just that a fresh checkout from github (i.e. without my PR) doesn't complete tests cleanly.

Leiningen 2.9.5 on Java 11.0.6 Java HotSpot(TM) 64-Bit Server VM
$ lein test

lein test lein-modules.compression-test

lein test lein-modules.inheritance-test

lein test :only lein-modules.inheritance-test/active-profiles-should-be-applied-to-all-parents

FAIL in (active-profiles-should-be-applied-to-all-parents) (inheritance_test.clj:73)
expected: (= "baz" (:foo p))
  actual: (not (= "baz" nil))

lein test :only lein-modules.inheritance-test/inheritance-should-work-without-config

FAIL in (inheritance-should-work-without-config) (inheritance_test.clj:80)
expected: (deps (quote [kidA/kidA "0.1.0-SNAPSHOT"]))
  actual: nil

lein test lein-modules.plugin-test

lein test lein-modules.versionization-test

lein test :only lein-modules.versionization-test/versionization-by-profile

FAIL in (versionization-by-profile) (versionization_test.clj:36)
expected: (= "2" (-> p (prj/merge-profiles [:by-child :skip-parent]) versions :v))
  actual: (not (= "2" "1"))

lein test leiningen.modules-test
No modules found
Checkouts for child
sibling -> /Users/pgearon/dev/oss/tmp/lein-modules/test-resources/grandparent/parent/sibling
 Module build order:
   parent
   sibling
   child
 Module build order:
   child

Ran 26 tests containing 88 assertions.
3 failures, 0 errors.
Tests failed.
Tests failed.

@jceaser
Copy link

jceaser commented May 10, 2024

I don't know about the testing part of this, but I do wish we could get this fix in as these classpath warnings really annoy me. Anyone else have a chance to look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants