Fix building issues #118
Open
Fix building issues #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 26, 2020 18:49
Squashed commit of the following: commit 50b5f12 Author: Roland Laurès <[email protected]> Date: Wed Aug 26 18:45:30 2020 +0200 Add new needed parameter because of --skip-bundle
Squashed commit of the following: commit fecc5c8 Author: Roland Laurès <[email protected]> Date: Wed Aug 26 23:36:10 2020 +0200 Fix Chromiumdriver start and connexion commit 6fd87e8 Author: Roland Laurès <[email protected]> Date: Wed Aug 26 23:21:41 2020 +0200 Use webdrivers gem instead of chromedriver-helper commit 2acad93 Author: Roland Laurès <[email protected]> Date: Wed Aug 26 18:44:01 2020 +0200 Just add a gem to help debug commit 4e83d27 Author: Roland Laurès <[email protected]> Date: Wed Aug 26 18:13:53 2020 +0200 Adding debug port to Chrome driver
ShamoX
changed the title
|
Needed to upgrade minor ruby versions for 2.5 which was failing missing URI::Generic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the build fail is from the fact that new rails app seems to have defaults some options that are not compatible with --skip-bundle.
rails/rails#28916
So I had to add few other --skip-* options to make it work like the tests expects it to work