Update parent pom #105
Update parent pom #105
Conversation
allow compile with java 11
Help NeededI have tried everything but I couldn't figure out how to pass all the checks. |
pom.xml
Outdated
| @@ -70,7 +71,7 @@ | |||
| <dependencies> | |||
| <dependency> | |||
| <groupId>io.jenkins.tools.bom</groupId> | |||
| <artifactId>bom-2.332.x</artifactId> | |||
| <artifactId>bom-2.401.x</artifactId> | |||
| <version>1466.v85a_616ea_b_87c</version> | |||
There was a problem hiding this comment.
If you're changing the artifactId you'll also need to change the version to one that exists. Your current build error is artifact not found.
There was a problem hiding this comment.
List of bill of materials releases by version are available from the BOM releases page for active versions and in the "Depending on older versions" table for inactive versions
The "Improve a plugin" tutorial that updates the base Jenkins version includes guidance on this step.
There was a problem hiding this comment.
Thanks for pointing this mistake/
|
Do I need to change more in pom.xml file like changing tha packaging type? |
No. The changes you've made are correct and complete. The Jenkinsfile that is run by ci.jenkins.io is from the master branch, nof from your pull request. I used my admin privileges on ci.jenkins.io to run the job with your Jenkinsfile. |
|
Mark can you tell me what should i do in my upcoming Pull request so that all the checks will pass in first go? Is this possible? |
If you are changing the Jenkinsfile and are not a maintainer of the plugin, then your changes will not be executed by ci.jenkins.io because we don't want the ci.jenkins.io executors to be misused by malicious users submitting changes to a Jenkinsfile |
allow compilation with java 11