Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade matrix-project test dependency based on plugin BOM results #1712

Merged

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Jan 20, 2025

Upgrade matrix-project test dependency based on plugin BOM results

The 2.452.x plugin bill of materials has reached end of life so this workaround can be upgraded to a newer version of matrix-project plugin.

Retain the workaround because the pipeline model definition plugin fails to start on the 2.479.x and 2.492.x lines if the workaround is removed.

Also remove some unnecessary exclusions and low value comments from the pom file.

Reverts and modifies pull request:

Testing done

Confirmed that the plugin BOM tests pass with a pre-release

export PLUGINS=pipeline-model-definition
export TEST=InjectedTest
LINE=2.462.x bash local-test.sh
LINE=2.479.x bash local-test.sh
LINE=2.492.x bash local-test.sh
LINE=weekly  bash local-test.sh

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

The 2.452.x plugin bill of materials has reached end of life so this
workaround can be upgraded to a newer version of matrix-project plugin.

Retain the workaround because the pipeline model definition plugin fails
to start on the 2.479.x and 2.492.x lines if the workaround is removed.

Testing done:

Confirmed that the plugin BOM tests pass with a pre-release

  export PLUGINS=pipeline-model-definition
  export TEST=InjectedTest
  LINE=2.462.x bash local-test.sh
  LINE=2.479.x bash local-test.sh
  LINE=2.492.x bash local-test.sh
  LINE=weekly  bash local-test.sh
@MarkEWaite MarkEWaite requested a review from a team as a code owner January 20, 2025 16:44
@MarkEWaite MarkEWaite added the test Automated test addition or improvement label Jan 20, 2025
@github-actions github-actions bot added the dependencies Dependency related change label Jan 20, 2025
@MarkEWaite MarkEWaite removed the dependencies Dependency related change label Jan 20, 2025
@MarkEWaite MarkEWaite merged commit aa8526f into jenkinsci:master Jan 20, 2025
18 checks passed
@MarkEWaite MarkEWaite deleted the update-matrix-project-workaround branch January 20, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Automated test addition or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant