-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Pipeline support for Batch and PowerShell #6
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure what the goal of this PR is, but I am pretty sure you do not want to be doing this.
I suppose this is adding some kind of Pipeline compatibility to this plugin? But none is needed. You just would not use this plugin if you were writing Pipeline. There is a much more general Groovy library feature. |
I didn't realize that works for batch and powershell, I thought it was for
groovy only.
…On Tue, Oct 30, 2018 at 10:07 AM Jesse Glick ***@***.***> wrote:
I suppose this is adding some kind of Pipeline compatibility to this
plugin? But none is needed. You just would not use this plugin if you were
writing Pipeline. There is a much more general Groovy library feature.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ASZaJSrAuQbZO_bhOid_aORkLQMn4NuAks5uqF0PgaJpZM4WP_1i>
.
|
I do not think you understand what I said. If you are using Pipeline, which is written in a Groovy dialect, you can also use libraries written in that same Groovy dialect. Among many other things, these libraries could encapsulate |
@jglick As this contains a lot of your code from the durable task step plugin, I thought you might want to review the change.