Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Pipeline support for Batch and PowerShell #6

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

mdkf
Copy link

@mdkf mdkf commented Aug 28, 2018

@jglick As this contains a lot of your code from the durable task step plugin, I thought you might want to review the change.

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what the goal of this PR is, but I am pretty sure you do not want to be doing this.

@jglick
Copy link
Member

jglick commented Oct 30, 2018

I suppose this is adding some kind of Pipeline compatibility to this plugin? But none is needed. You just would not use this plugin if you were writing Pipeline. There is a much more general Groovy library feature.

@mdkf
Copy link
Author

mdkf commented Oct 30, 2018 via email

@jglick
Copy link
Member

jglick commented Nov 19, 2018

I do not think you understand what I said. If you are using Pipeline, which is written in a Groovy dialect, you can also use libraries written in that same Groovy dialect. Among many other things, these libraries could encapsulate bat or powershell calls in more abstract functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants