Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the _matchAfterIndex variable after setting new filter mappings #12725

Open
wants to merge 1 commit into
base: jetty-12.0.x
Choose a base branch
from

Conversation

kshep92
Copy link

@kshep92 kshep92 commented Jan 21, 2025

Updates the _matchAfterIndex to the correct value based on how many filter mappings the user added to the ServletHandler. Failing to do so produces an IndexOutOfBoundsException when adding subsequent filter mappings.

Updates the _matchAfterIndex to the correct value based on how many filter mappings the user added to the ServletHandler. Failing to do so produces an IndexOutOfBoundsException when adding subsequent filter mappings.
@joakime
Copy link
Contributor

joakime commented Jan 21, 2025

Thank you for the PR, but ...

First, we need an ECA to merge this. See CONTRIBUTING.md
Second, we need a testcase that shows the issue (as this often shows a different place, or more places, that the issue should be corrected in)

@kshep92
Copy link
Author

kshep92 commented Jan 22, 2025

Thank you for your guidance @joakime I was unable to create an account on the Eclipse foundation website as it's showing me an error page after submitting the registration form. I will try again later. In the meantime, I've attached a test case for examination.
jetty-test-case.zip

@janbartel
Copy link
Contributor

@kshep92 thanks for the PR, you are on the right track, but I think we need to do a full reset of both indexes. I've opened PR #12734 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants