review comments

jfalcou · Jan 24, 2025 · 65ffa75 · 65ffa75
1 parent f20ab2f
commit 65ffa75
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/include/eve/module/core/regular/impl/is_less.hpp b/include/eve/module/core/regular/impl/is_less.hpp
@@ -14,8 +14,6 @@ namespace eve::detail
   {
     if constexpr (O::contains(definitely))
     {
-      static_assert(floating_value<T>, "[eve::is_less] The definitely option is only supported for floating types.");
-
       auto tol = o[definitely].value(T{});
 
       if constexpr (integral_value<decltype(tol)>) return a < eve::prev(b, tol);

diff --git a/include/eve/module/core/regular/is_less.hpp b/include/eve/module/core/regular/is_less.hpp
@@ -29,6 +29,10 @@ namespace eve
     constexpr EVE_FORCEINLINE common_logical_t<T, U> operator()(T a, U b) const
       requires (compatible_arithmetic_values<T, U>)
     {
+      if constexpr (Options::contains(definitely))
+      {
+        static_assert(floating_value<T>, "[eve::is_less] The definitely option is only supported for floating types.");
+      }
       //      static_assert( valid_tolerance<common_value_t<T, U>, Options>::value, "[eve::is_less] simd tolerance requires at least one simd parameter." );
       return EVE_DISPATCH_CALL(a, b);
     }