Better overload #1679

jfalcou · 2023-09-21T16:58:17Z

After some more discussions, this implements a 3rd version of our overload system.

include/eve/traits/overload/default_behaviors.hpp

include/eve/traits/overload/protocol.hpp

include/eve/traits/overload/supports.hpp

test/doc/traits/callable_constant.cpp

test/doc/traits/callable_object.cpp

test/doc/traits/callable_specs.cpp

DenisYaroshevskiy · 2023-09-22T00:58:05Z

FYI, this how I'd like "supports" to look


struct conditional_relative_in_out {
  template <rbr::concepts::settings Settings>
  EVE_FORCEINLINE
  static constexpr auto process_option(options<Settings> opt, eve::relative_conditional_expr auto ignore) 
  {
     if constexpr ( Settings::contains(out_ignore) ) { static_assert("Only supports 'in' and 'out' ignore"); }
     else if constexpr ( Settings::contains(in_ignore) ) { return default_to( opt, options(out_ignore = ignore) ); }
     else return default_to( opt, options(in_ignore = ignore) ); }
  }

  template <rbr::concepts::settings Settings>
  EVE_FORCEINLINE
  static constexpr auto defaults(options<Settings> opt) 
  {
     auto in = default_to(opt, options(in_ignore = ignore_none);
     return default_to(in, options(out_ignore = in[in_ignore]);
  }
};

jfalcou · 2023-09-22T06:21:45Z

FYI, this how I'd like "supports" to look


struct conditional_relative_in_out {
  template <rbr::concepts::settings Settings>
  EVE_FORCEINLINE
  static constexpr auto process_option(options<Settings> opt, eve::relative_conditional_expr auto ignore) 
  {
     if constexpr ( Settings::contains(out_ignore) ) { static_assert("Only supports 'in' and 'out' ignore"); }
     else if constexpr ( Settings::contains(in_ignore) ) { return default_to( opt, options(out_ignore = ignore) ); }
     else return default_to( opt, options(in_ignore = ignore) ); }
  }

  template <rbr::concepts::settings Settings>
  EVE_FORCEINLINE
  static constexpr auto defaults(options<Settings> opt) 
  {
     auto in = default_to(opt, options(in_ignore = ignore_none);
     return default_to(in, options(out_ignore = in[in_ignore]);
  }
};

what's default_to here ?

DenisYaroshevskiy · 2023-09-22T09:16:28Z

what's default_to here ?

options{rbr::merge(op, defaults)};

include/eve/traits/overload/default_behaviors.hpp

jfalcou · 2023-10-13T21:19:11Z

Applied most of the discussed changes.
Names etc still open if you want to have a 2nd go

include/eve/traits/overload/default_behaviors.hpp

include/eve/traits/overload/protocol.hpp

include/eve/traits/overload/supports.hpp

test/doc/traits/callable_specs.cpp

include/eve/traits/overload/protocol.hpp

include/eve/traits/overload/default_behaviors.hpp

include/eve/traits/overload/protocol.hpp

include/eve/traits/overload/default_behaviors.hpp

include/eve/traits/overload/protocol.hpp

include/eve/traits/overload/supports.hpp

include/eve/traits/overload/default_behaviors.hpp

include/eve/traits/overload/supports.hpp

DenisYaroshevskiy · 2023-10-15T18:34:50Z

include/eve/traits/overload/supports.hpp

+
+    /// Default settings of eve::conditional is eve::ignore_none
+    EVE_FORCEINLINE static constexpr auto defaults() noexcept { return options{condition_key = ignore_none};  }
+  };


hmm, do we want to just inherit relative_condition_option?

I was thinking about it but wasn't sure.

test/doc/traits/callable_object.cpp

test/doc/traits/callable_specs.cpp

- Made rbr concepts usable in EVE - Fixed constant with else - Clean up here and there

include/eve/traits/overload/default_behaviors.hpp

test/doc/traits/callable_object.cpp

test/doc/traits/callable_object_from.cpp

test/doc/traits/callable_specs.cpp

test/doc/traits/callable_supports.cpp

DenisYaroshevskiy

Will look more

include/eve/traits/overload/default_behaviors.hpp

include/eve/traits/overload/supports.hpp

DenisYaroshevskiy

I will approve. I don't think we quite understand everything yet and there are some flaws I am seeing, but they need expirience

include/eve/traits/invoke/protocol.hpp

include/eve/traits/overload/default_behaviors.hpp

DenisYaroshevskiy · 2023-11-18T10:22:29Z

include/eve/traits/overload/default_behaviors.hpp

+        auto const f        = Func<decltype(rmv_cond)>{rmv_cond};
+
+        // If the conditional call is supported, call it
+        if      constexpr( is_supported ) return detail::mask_op(cond, f, x0, xs...);


I am not sure if I understand how you plan to support conditionals.

You say is_supported for a conditional call. What would that spec look like?

Alternatively - it should always be supported and this just keeps being in all overloads.

Yup this is fishy, removign elementwise for now as discussed

DenisYaroshevskiy · 2023-11-18T10:24:57Z

include/eve/traits/overload/default_behaviors.hpp

+      constexpr bool any_simd     = (simd_value<T> || ... || simd_value<Ts>);
+
+      // Are we dealing with a no-condition call ?
+      if constexpr( option_type_is<condition_key, O, ignore_none_> )


Ignore all support?

Do we have a uniform logic on how we handle ignores in element wise?

I think this is a bit lacking indeed

DenisYaroshevskiy reviewed Sep 22, 2023

View reviewed changes

jfalcou force-pushed the feat/better-overload branch from bbc60af to d08f867 Compare October 3, 2023 19:16

DenisYaroshevskiy reviewed Oct 3, 2023

View reviewed changes

include/eve/traits/overload/default_behaviors.hpp Outdated Show resolved Hide resolved

jfalcou force-pushed the feat/better-overload branch 3 times, most recently from 549bc97 to cb9e54f Compare October 13, 2023 20:39

DenisYaroshevskiy reviewed Oct 15, 2023

View reviewed changes

jfalcou added 17 commits November 12, 2023 15:06

First batch of the new overload system

549caf6

More documentation

56e2274

Restructure files

94ee50d

constant doc tests

e14ccce

More doc

8e7325f

Some trivial cleanup

7da745d

All callable receive options that may eb empty anyway

58b3c39

Remove option:: namespace

09f23db

Make support Specificatiosn do stuff now

ae8ddd5

Change the requirement test on supports[] to accomodate g++-aarch64

156b5b7

Add a relative_conditional specifications for support

ed0c4f7

Names & missign explicit

73053ba

conditonal -> conditional_options

7d0ce6a

Fix doc

85a8953

More fixes from Dennis' remarks

abdf5f0

Simplify the default behavior process

347226c

Naming around default_behavior

2c680cf

jfalcou added 5 commits November 12, 2023 15:06

More Dennis' remarks

ac4b3ba

- Made rbr concepts usable in EVE - Fixed constant with else - Clean up here and there

Rework with better design

116d330

Use newer Docker with clang++-15

f411dc4

Adapt tests to latest version of dispatching mecanism

d94c9e2

Use proper clang++ path in CI

14a7d0a

jfalcou force-pushed the feat/better-overload branch from 0144458 to 14a7d0a Compare November 12, 2023 14:06

jfalcou added 4 commits November 12, 2023 17:28

Add constructor so that arm gcc is happy

5b37502

Make as constructor explicit to prevent false positive in overload

a334e98

Final touch on elementwise/constant_callable

b3f59f5

Adapt constant tests

57fa216

DenisYaroshevskiy reviewed Nov 14, 2023

View reviewed changes

More Dennis' remarks

9520533

DenisYaroshevskiy reviewed Nov 17, 2023

View reviewed changes

include/eve/traits/overload/default_behaviors.hpp Outdated Show resolved Hide resolved

include/eve/traits/overload/supports.hpp Outdated Show resolved Hide resolved

Final cleanup

73cd3d4

DenisYaroshevskiy approved these changes Nov 18, 2023

View reviewed changes

jfalcou merged commit 9c9e7e3 into main Nov 18, 2023
35 checks passed

jfalcou deleted the feat/better-overload branch November 18, 2023 17:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Better overload #1679

Better overload #1679

jfalcou commented Sep 21, 2023

DenisYaroshevskiy commented Sep 22, 2023

jfalcou commented Sep 22, 2023

DenisYaroshevskiy commented Sep 22, 2023

jfalcou commented Oct 13, 2023

DenisYaroshevskiy Oct 15, 2023

jfalcou Oct 15, 2023

DenisYaroshevskiy left a comment

DenisYaroshevskiy left a comment

DenisYaroshevskiy Nov 18, 2023

jfalcou Nov 18, 2023

DenisYaroshevskiy Nov 18, 2023

jfalcou Nov 18, 2023

Better overload #1679

Better overload #1679

Conversation

jfalcou commented Sep 21, 2023

DenisYaroshevskiy commented Sep 22, 2023

jfalcou commented Sep 22, 2023

DenisYaroshevskiy commented Sep 22, 2023

jfalcou commented Oct 13, 2023

DenisYaroshevskiy Oct 15, 2023

Choose a reason for hiding this comment

jfalcou Oct 15, 2023

Choose a reason for hiding this comment

DenisYaroshevskiy left a comment

Choose a reason for hiding this comment

DenisYaroshevskiy left a comment

Choose a reason for hiding this comment

DenisYaroshevskiy Nov 18, 2023

Choose a reason for hiding this comment

jfalcou Nov 18, 2023

Choose a reason for hiding this comment

DenisYaroshevskiy Nov 18, 2023

Choose a reason for hiding this comment

jfalcou Nov 18, 2023

Choose a reason for hiding this comment