Move self_less to the is_less callable #2048
Merged
+398
−291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SadiinsoSnowfall
force-pushed
the
callable/cmp-less
branch
from
368b09f to
81f644d
Compare
SadiinsoSnowfall
force-pushed
the
callable/cmp-less
branch
from
a6e4ffb to
57be875
Compare
|
How to forward declare the common_logical: https://godbolt.org/z/v3T1Pofbn |
| namespace eve::detail | ||
| { | ||
| template<callable_options O, typename T> | ||
| EVE_FORCEINLINE constexpr common_logical_t<T> is_less_(EVE_REQUIRES(cpu_), O const& o, T a, T b) noexcept |
There was a problem hiding this comment.
common_logical_t makes no sense
| { | ||
| // static_assert( valid_tolerance<common_value_t<T, U>, Options>::value, "[eve::is_less] simd tolerance requires at least one simd parameter." ); | ||
| return EVE_DISPATCH_CALL(a, b); | ||
| } | ||
|
|
||
| template<arithmetic_value T, arithmetic_value U> | ||
| constexpr EVE_FORCEINLINE common_logical_t<T, U> operator()(T a, U b) const | ||
| requires (compatible_arithmetic_values<T, U> && !Options::contains(definitely)) |
There was a problem hiding this comment.
decided to static assert for now
There was a problem hiding this comment.
Reverted to the static_assert
| constexpr EVE_FORCEINLINE common_logical_t<T,U> operator()(T a, U b) const | ||
| template<arithmetic_value T, arithmetic_value U> | ||
| constexpr EVE_FORCEINLINE common_logical_t<T, U> operator()(T a, U b) const | ||
| requires (compatible_arithmetic_values<T, U>) |
There was a problem hiding this comment.
put the static assert in the interface please
DenisYaroshevskiy
approved these changes
Jan 24, 2025
jfalcou
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.