Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GDSL definition for realms plugin #297

Closed
wants to merge 2 commits into from

Conversation

sluongng
Copy link

Fix: #292

Problem:

Fix:

  • Reformat gdsl to a more human readable style
  • add groups and user properties under authenticate closure
  • add an annonymous method(no name) definition under realms

This fix should make current gdsl compatible with latest IntelliJ when run against some of the realms example plugin within this repo

Son Luong Ngoc added 2 commits October 17, 2019 10:45
- reformat into multiple lines
- added 'scope:' in front of scriptScope() to fix IntelliJ warning
- Improved type from 'groovy.lang.Closure' to {}
- Added method definitions for Realms call
- Added property definitions and Authenticate call
@sluongng
Copy link
Author

@jfrog-aparicio do you know how could i get a review and merge for this PR?

@CLAassistant
Copy link

CLAassistant commented Jun 20, 2020

CLA assistant check
All committers have signed the CLA.

@sluongng sluongng closed this May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Realms GDSL definition need to be updated
2 participants