remoteBackup: fix invalid config file breaks Artifactory instance #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ |
diepfote
force-pushed
the
fbegusch-fix-non-existent-config-file-breaks-artifactory
branch
2 times, most recently
from
be393af to
c0a14a6
Compare
|
I have read the CLA Document and I hereby sign the CLA |
diepfote
force-pushed
the
fbegusch-fix-non-existent-config-file-breaks-artifactory
branch
from
c0a14a6 to
be393af
Compare
|
|
||
| // Ensure invalid json config does not prevent Artifactory | ||
| // from serving and receiving artifacts. | ||
| if (!cfgfile.exists()) return |
There was a problem hiding this comment.
A log message for this event would be nice.
diepfote
force-pushed
the
fbegusch-fix-non-existent-config-file-breaks-artifactory
branch
from
be393af to
af9c02d
Compare
diepfote
force-pushed
the
fbegusch-fix-non-existent-config-file-breaks-artifactory
branch
from
af9c02d to
e01bd91
Compare
|
@DarthFennec Can you please provide a review? |
diepfote
force-pushed
the
fbegusch-fix-non-existent-config-file-breaks-artifactory
branch
2 times, most recently
from
1e443b4 to
e01bd91
Compare
|
@diepfote Are you still looking for this change? Its been open for long time. |
|
@yashprit-jfrog we integrated this internally. Feel free to close |
|
Closing based on above comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.