Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some checks and asserts where it makes sense #28382

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Tcharl
Copy link
Contributor

@Tcharl Tcharl commented Jan 4, 2025

Move some checks to more relevant generators to avoid potential bugs


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@Tcharl Tcharl requested a review from mshima January 8, 2025 21:42
@Tcharl Tcharl marked this pull request as draft January 9, 2025 17:54
@Tcharl Tcharl marked this pull request as ready for review January 9, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants