Incremental write #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I have improved the implementation of A::T::add_fileref - started disliking it when cycling home yesterday :-). Best regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Chris and others,
I have implemented the first version of incremental/buffered/lazy writes.
The implementation includes tests, and it seems to work properly.
However, I am not convinced that the way to augment the present functionality is the best one,
although it's 100% not colliding with existing code.
The possibility to rename files via add_data is also a feature I need.
Today I use an Archive::Tar::Streamed like workaround in production, which has shown some problems with files > 2 GB;
before re-inventing the wheel in too many places, I thought fixing the original would be a more efficient strategy :-).
It would be great if you could consider merging in or using my changes, since I would need to have some kind of stable result ...
Best regards,
Markus
P.S.: I also marked a place where I think that following symlinks is done far too late.