Fix Buildkite warnings #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalu
approved these changes
Nov 10, 2023
buffalu
added a commit
that referenced
this pull request
Nov 14, 2023
Use cluster info functions for tpu (#345) (#347) Use git rev-parse for git sha Remove blacklisted tx from message_hash_to_transaction (Backport #374) (#376) Updates scripts for easy local setup. (#383) Backports sim_bundle improvements (#407) backports clone derivation 416 (#417) Backport #419: add upsert to AccountOverrides (#420) backports #430 v1.16: update jito-programs sha (#431) [JIT-1661] Faster Autosnapshot (#406) Fix Buildkite warnings (#437) Backport #446 to v1.16 (#447) backport 428, runtime plugin (#429) v1.16: Backport #449 (#450)
buffalu
added a commit
that referenced
this pull request
Nov 14, 2023
Use cluster info functions for tpu (#345) (#347) Use git rev-parse for git sha Remove blacklisted tx from message_hash_to_transaction (Backport #374) (#376) Updates scripts for easy local setup. (#383) Backports sim_bundle improvements (#407) backports clone derivation 416 (#417) Backport #419: add upsert to AccountOverrides (#420) backports #430 v1.16: update jito-programs sha (#431) [JIT-1661] Faster Autosnapshot (#406) Fix Buildkite warnings (#437) Backport #446 to v1.16 (#447) backport 428, runtime plugin (#429) v1.16: Backport #449 (#450)
buffalu
added a commit
that referenced
this pull request
Nov 15, 2023
Use cluster info functions for tpu (#345) (#347) Use git rev-parse for git sha Remove blacklisted tx from message_hash_to_transaction (Backport #374) (#376) Updates scripts for easy local setup. (#383) Backports sim_bundle improvements (#407) backports clone derivation 416 (#417) Backport #419: add upsert to AccountOverrides (#420) backports #430 v1.16: update jito-programs sha (#431) [JIT-1661] Faster Autosnapshot (#406) Fix Buildkite warnings (#437) Backport #446 to v1.16 (#447) backport 428, runtime plugin (#429) v1.16: Backport #449 (#450)
buffalu
added a commit
that referenced
this pull request
Dec 4, 2023
Use cluster info functions for tpu (#345) (#347) Use git rev-parse for git sha Remove blacklisted tx from message_hash_to_transaction (Backport #374) (#376) Updates scripts for easy local setup. (#383) Backports sim_bundle improvements (#407) backports clone derivation 416 (#417) Backport #419: add upsert to AccountOverrides (#420) backports #430 v1.16: update jito-programs sha (#431) [JIT-1661] Faster Autosnapshot (#406) Fix Buildkite warnings (#437) Backport #446 to v1.16 (#447) backport 428, runtime plugin (#429) v1.16: Backport #449 (#450)
buffalu
added a commit
that referenced
this pull request
Dec 5, 2023
Use cluster info functions for tpu (#345) (#347) Use git rev-parse for git sha Remove blacklisted tx from message_hash_to_transaction (Backport #374) (#376) Updates scripts for easy local setup. (#383) Backports sim_bundle improvements (#407) backports clone derivation 416 (#417) Backport #419: add upsert to AccountOverrides (#420) backports #430 v1.16: update jito-programs sha (#431) [JIT-1661] Faster Autosnapshot (#406) Fix Buildkite warnings (#437) Backport #446 to v1.16 (#447) backport 428, runtime plugin (#429) v1.16: Backport #449 (#450)
buffalu
added a commit
that referenced
this pull request
Dec 5, 2023
Use cluster info functions for tpu (#345) (#347) Use git rev-parse for git sha Remove blacklisted tx from message_hash_to_transaction (Backport #374) (#376) Updates scripts for easy local setup. (#383) Backports sim_bundle improvements (#407) backports clone derivation 416 (#417) Backport #419: add upsert to AccountOverrides (#420) backports #430 v1.16: update jito-programs sha (#431) [JIT-1661] Faster Autosnapshot (#406) Fix Buildkite warnings (#437) Backport #446 to v1.16 (#447) backport 428, runtime plugin (#429) v1.16: Backport #449 (#450)
buffalu
added a commit
that referenced
this pull request
Dec 11, 2023
Use cluster info functions for tpu (#345) (#347) Use git rev-parse for git sha Remove blacklisted tx from message_hash_to_transaction (Backport #374) (#376) Updates scripts for easy local setup. (#383) Backports sim_bundle improvements (#407) backports clone derivation 416 (#417) Backport #419: add upsert to AccountOverrides (#420) backports #430 v1.16: update jito-programs sha (#431) [JIT-1661] Faster Autosnapshot (#406) Fix Buildkite warnings (#437) Backport #446 to v1.16 (#447) backport 428, runtime plugin (#429) v1.16: Backport #449 (#450)
buffalu
added a commit
that referenced
this pull request
Dec 12, 2023
Use cluster info functions for tpu (#345) (#347) Use git rev-parse for git sha Remove blacklisted tx from message_hash_to_transaction (Backport #374) (#376) Updates scripts for easy local setup. (#383) Backports sim_bundle improvements (#407) backports clone derivation 416 (#417) Backport #419: add upsert to AccountOverrides (#420) backports #430 v1.16: update jito-programs sha (#431) [JIT-1661] Faster Autosnapshot (#406) Fix Buildkite warnings (#437) Backport #446 to v1.16 (#447) backport 428, runtime plugin (#429) v1.16: Backport #449 (#450)
buffalu
added a commit
that referenced
this pull request
Dec 16, 2023
Use cluster info functions for tpu (#345) (#347) Use git rev-parse for git sha Remove blacklisted tx from message_hash_to_transaction (Backport #374) (#376) Updates scripts for easy local setup. (#383) Backports sim_bundle improvements (#407) backports clone derivation 416 (#417) Backport #419: add upsert to AccountOverrides (#420) backports #430 v1.16: update jito-programs sha (#431) [JIT-1661] Faster Autosnapshot (#406) Fix Buildkite warnings (#437) Backport #446 to v1.16 (#447) backport 428, runtime plugin (#429) v1.16: Backport #449 (#450) [JIT-1713] Fix bundle's blockspace preallocation (Backport to 1.16) (#498) Backport #500 to v1.16 (#506)
buffalu
added a commit
that referenced
this pull request
Dec 16, 2023
Use cluster info functions for tpu (#345) (#347) Use git rev-parse for git sha Remove blacklisted tx from message_hash_to_transaction (Backport #374) (#376) Updates scripts for easy local setup. (#383) Backports sim_bundle improvements (#407) backports clone derivation 416 (#417) Backport #419: add upsert to AccountOverrides (#420) backports #430 v1.16: update jito-programs sha (#431) [JIT-1661] Faster Autosnapshot (#406) Fix Buildkite warnings (#437) Backport #446 to v1.16 (#447) backport 428, runtime plugin (#429) v1.16: Backport #449 (#450) [JIT-1713] Fix bundle's blockspace preallocation (Backport to 1.16) (#498) Backport #500 to v1.16 (#506)
buffalu
added a commit
that referenced
this pull request
Dec 18, 2023
Use cluster info functions for tpu (#345) (#347) Use git rev-parse for git sha Remove blacklisted tx from message_hash_to_transaction (Backport #374) (#376) Updates scripts for easy local setup. (#383) Backports sim_bundle improvements (#407) backports clone derivation 416 (#417) Backport #419: add upsert to AccountOverrides (#420) backports #430 v1.16: update jito-programs sha (#431) [JIT-1661] Faster Autosnapshot (#406) Fix Buildkite warnings (#437) Backport #446 to v1.16 (#447) backport 428, runtime plugin (#429) v1.16: Backport #449 (#450) [JIT-1713] Fix bundle's blockspace preallocation (Backport to 1.16) (#498) Backport #500 to v1.16 (#506)
buffalu
added a commit
that referenced
this pull request
Jan 5, 2024
Use cluster info functions for tpu (#345) (#347) Use git rev-parse for git sha Remove blacklisted tx from message_hash_to_transaction (Backport #374) (#376) Updates scripts for easy local setup. (#383) Backports sim_bundle improvements (#407) backports clone derivation 416 (#417) Backport #419: add upsert to AccountOverrides (#420) backports #430 v1.16: update jito-programs sha (#431) [JIT-1661] Faster Autosnapshot (#406) Fix Buildkite warnings (#437) Backport #446 to v1.16 (#447) backport 428, runtime plugin (#429) v1.16: Backport #449 (#450) [JIT-1713] Fix bundle's blockspace preallocation (Backport to 1.16) (#498) Backport #500 to v1.16 (#506) backports #520: add priority fees to mev claim (#524) Backport #548 (#549)
buffalu
added a commit
that referenced
this pull request
Jan 5, 2024
Use cluster info functions for tpu (#345) (#347) Use git rev-parse for git sha Remove blacklisted tx from message_hash_to_transaction (Backport #374) (#376) Updates scripts for easy local setup. (#383) Backports sim_bundle improvements (#407) backports clone derivation 416 (#417) Backport #419: add upsert to AccountOverrides (#420) backports #430 v1.16: update jito-programs sha (#431) [JIT-1661] Faster Autosnapshot (#406) Fix Buildkite warnings (#437) Backport #446 to v1.16 (#447) backport 428, runtime plugin (#429) v1.16: Backport #449 (#450) [JIT-1713] Fix bundle's blockspace preallocation (Backport to 1.16) (#498) Backport #500 to v1.16 (#506) backports #520: add priority fees to mev claim (#524) Backport #548 (#549)
buffalu
added a commit
that referenced
this pull request
Jan 6, 2024
Use cluster info functions for tpu (#345) (#347) Use git rev-parse for git sha Remove blacklisted tx from message_hash_to_transaction (Backport #374) (#376) Updates scripts for easy local setup. (#383) Backports sim_bundle improvements (#407) backports clone derivation 416 (#417) Backport #419: add upsert to AccountOverrides (#420) backports #430 v1.16: update jito-programs sha (#431) [JIT-1661] Faster Autosnapshot (#406) Fix Buildkite warnings (#437) Backport #446 to v1.16 (#447) backport 428, runtime plugin (#429) v1.16: Backport #449 (#450) [JIT-1713] Fix bundle's blockspace preallocation (Backport to 1.16) (#498) Backport #500 to v1.16 (#506) backports #520: add priority fees to mev claim (#524) Backport #548 (#549)
buffalu
pushed a commit
that referenced
this pull request
Jul 18, 2024
When a leader is packing a Bank, transactions costs are added to the CostTracker and then later updated or removed, depending on if the tx is committed. However, it is possible for a Bank to be frozen while there are several tx's in flight. CostUpdateService submits a metric with cost information almost immediately after a Bank has been frozen. The result is that we have observed cost details being submitted before some cost removals take place, which causes a massive over-reporting of the block cost compared to actual. This PR adds a field to track the number of transactions that are inflight, and adds a simple mechanism to try to allow that value to settle to zero before submitting the datapoint. The number of inflight tx's is submitted with the datapoint, so even if the value does not settle to zero, we can still detect this case and know the metric is tainted. Co-authored-by: Andrew Fitzgerald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix warnings introduced in #406