[JIT-1712] Fix BundleStorage rebuffering #487
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segfaultdoc
reviewed
Dec 1, 2023
jedleggett
reviewed
Dec 8, 2023
| ImmutableDeserializedBundle, | ||
| )>, | ||
| ) -> Self { | ||
| Self::new_bundle_storage_ttl( |
There was a problem hiding this comment.
nit: why does this need to be a separate function call?
There was a problem hiding this comment.
this was to avoid modifying all the call sites with the TTL info
segfaultdoc
reviewed
Dec 11, 2023
| ) | ||
| } | ||
|
|
||
| pub fn new_bundle_storage_ttl( |
esemeniuc
force-pushed
the
eric/rebuffer_master
branch
from
993f46a to
7298ee7
Compare
buffalu
pushed a commit
that referenced
this pull request
Apr 1, 2024
ci: add release pipeline (#466) (cherry picked from commit 212cbdb) Co-authored-by: Yihau Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Bundles may be rebuffered for longer than necessary when cost model checks fail.
Summary of Changes
Fixes #