Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize Timely Vote Credits in Steward score #92

Merged
merged 12 commits into from
Dec 7, 2024
Merged

Conversation

ebatsell
Copy link
Collaborator

@ebatsell ebatsell commented Dec 1, 2024

Normalizes vote credits which are now 16x higher for validators starting in epoch 704.

@ebatsell ebatsell marked this pull request as ready for review December 3, 2024 23:57
Copy link
Contributor

@coachchucksol coachchucksol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -90,6 +90,7 @@ pub fn validator_score(
cluster: &ClusterHistory,
config: &Config,
current_epoch: u16,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current_epoch should be u64

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

legacy issue cause of ValidatorHistoryEntry trying to minimize bytes

@ebatsell ebatsell merged commit f86e28b into master Dec 7, 2024
6 checks passed
@ebatsell ebatsell deleted the evan/normalize-tvc branch December 7, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants