Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SSH upload and download functions #191

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Add SSH upload and download functions #191

merged 3 commits into from
Oct 10, 2023

Conversation

pyrech
Copy link
Member

@pyrech pyrech commented Oct 9, 2023

Fix #178

@pyrech pyrech force-pushed the ssh-upload-download branch from de6f2dd to a27c9ac Compare October 9, 2023 21:31
lyrixx
lyrixx reviewed Oct 10, 2023
View reviewed changes
examples/ssh.php Outdated Show resolved Hide resolved
examples/ssh.php Outdated Show resolved Hide resolved
examples/ssh.php Outdated Show resolved Hide resolved
mbrodala
mbrodala suggested changes Oct 10, 2023
View reviewed changes
tests/Examples/ListTest.php.output.txt Outdated Show resolved Hide resolved
src/functions.php Show resolved Hide resolved
@pyrech
Copy link
Member Author

pyrech commented Oct 10, 2023 •
edited
Loading

Thanks for your suggestions and reviews. I renamed ssh() to ssh_run() and added a deprecation when using the old naming to ease the upgrade.

@pyrech pyrech force-pushed the ssh-upload-download branch from dd99d83 to f77e4f6 Compare October 10, 2023 08:36
lyrixx
lyrixx reviewed Oct 10, 2023
View reviewed changes
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except one little comment, it's good 👍🏼

examples/ssh.php Outdated Show resolved Hide resolved
@pyrech pyrech force-pushed the ssh-upload-download branch from f77e4f6 to c062621 Compare October 10, 2023 08:39
@pyrech pyrech force-pushed the ssh-upload-download branch from c062621 to 3394c97 Compare October 10, 2023 09:00
@lyrixx lyrixx merged commit ae9e3c4 into main Oct 10, 2023
2 of 3 checks passed
@lyrixx lyrixx deleted the ssh-upload-download branch October 10, 2023 09:09
@lyrixx
Copy link
Member

lyrixx commented Oct 10, 2023

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx left review comments

@mbrodala mbrodala mbrodala requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add SSH upload/download functions
3 participants
@pyrech @lyrixx @mbrodala