-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHPStan level 8 compliance #324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is the right place for it, and we provide a PHPStan level 6 by default, but i won't vote against it 👍
This fix seems weird to me. Is there a better way to fix it? |
62a4816
to
4245ac4
Compare
Hi @lyrixx, I pushed another fix that seems better. I think we can set PHPStan level 8 by default as this boilerplate is mainly used to create new projects, WDYT? |
@@ -28,7 +28,6 @@ parameters: | |||
power_shell: bool, | |||
user_id: int, | |||
root_dir: string, | |||
env: string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in f495759
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4245ac4
to
d751fed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
To fix:
This may not be the cleanest way to do it, WDYT?