Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android security expose #74

Closed
wants to merge 3 commits into from

Conversation

Moreno97
Copy link

@Moreno97 Moreno97 commented Jun 14, 2018

Coming from wkh237#614
It solves the exposed security exception on Android devices with API version >= 24. In older API's the code hasn't changed, still uses file://....

@Bartlomiejsz
Copy link

Is there a chance it will be merged soon?

@Traviskn
Copy link

I need to check, but I think we had a similar PR merged into the 0.10.9 branch which has since been merged into master. I haven't checked out the 0.11.0 branch yet to see if it has significant work that we will want to merge into master.

Before moving to this fork, this repo used a lot of long-lived bug-fix and feature branches. I'm starting to think we would be better off avoiding long lived branches and just have PRs go towards master. Would we be able to re-open the PR against the master branch, so double check that a similar fix hasn't already been implemented there?

@Moreno97
Copy link
Author

Yes, it's merged now. But if you see the commit, the changes are very similar with my changes, although my commit on the other repo is older (source code copied?).
a88b59f

@Traviskn
Copy link

Traviskn commented Aug 6, 2018

It's possible the code was copied from the other repo by the contributor - sorry about that! In any case this issue should now be fixed. Thanks for your contributions!

@Traviskn Traviskn closed this Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants