Implementing time zone change #5 #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added setTimeZone function to lib Added 4 tests for the new function including GMT +/- for specific and current time also
Add fix to make test pass on non-GMT 0 locale machines
Added docs for new method to .verb.md Updated typdef file with the new method's signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR aims to implement the feature described in #5.
Here are some of the things I did:
I'm not sure what OP meant by setting time zone, the way I did it is it sets the timezone from the UTC time.
Example:
Let's suppose the time is 19:00:00 on a machine that's timezone is GMT +1.
We set time the timezone to GMT +2.
In this case my feature would return 20:00:00, because it's +2 from UTC time, and not from the given time.
Previous test case, that was broken:
I fixed a test case where it was testing the 2 digit format.
In this test case the input date is
2019-01-01 00:00:00but with the GMT offset of the current machine, in my case this offset is +1, so the UTC date for me was2018-12-31 23:00:00, which gives the 2 digit year of18instead of the expected19Building the docs:
I've read the guide in the readme file on building the docs, however I was unable to build the docs, because of an error that says
TypeError: expected helpers to be an object.If you could help me with what's wrong I could build the docs, because I'm not so familiar with
verb.I tried searching the docs but I haven't found anything related to the "helpers" package.json option.