Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/missing definitions #191

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

Arano-kai
Copy link
Contributor

What this PR does / why we need it:

The command, args, customLivenessProbe and customReadinessProbe
were not rendered due to the lack of definitions in the STS template.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you updated the readme?
  • Is this PR backward compatible? If it is not backward compatible, please discuss open a ticket first

Arano-kai added 2 commits August 15, 2024 19:08
The command, args, customLivenessProbe and customReadinessProbe
were not rendered due to the lack of definitions in the STS template.
- Add missing vars description
- Line up tables (thx to dhruvasagar/vim-table-mode)
@Arano-kai
Copy link
Contributor Author

It seems that check are failing due internal errors, not related to PR:
image

Anyway, @jp-gouin any opinion/suggestions regarding this fix-up?

@jp-gouin
Copy link
Owner

Oh, yeah

Can you edit .github/actions/setup/action.yaml

L21 : curl -Lo /tmp/kind https://kind.sigs.k8s.io/dl/v0.24.0/kind-linux-amd64
L28: /tmp/kind create cluster --config=$GITHUB_WORKSPACE/.bin/kind-conf.yml --image=kindest/node:v1.31.0@sha256:53df588e04085fd41ae12de0c3fe4c72f7013bba32a20e7325357a1ac94ba865

@Arano-kai
Copy link
Contributor Author

Oh, yeah

Can you edit .github/actions/setup/action.yaml

L21 : curl -Lo /tmp/kind https://kind.sigs.k8s.io/dl/v0.24.0/kind-linux-amd64 L28: /tmp/kind create cluster --config=$GITHUB_WORKSPACE/.bin/kind-conf.yml --image=kindest/node:v1.31.0@sha256:53df588e04085fd41ae12de0c3fe4c72f7013bba32a20e7325357a1ac94ba865

Done. And all checks now happy 🙃

@jp-gouin jp-gouin merged commit 1b9d78d into jp-gouin:master Oct 1, 2024
3 checks passed
@Arano-kai Arano-kai deleted the bugfix/missing_definitions branch October 1, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants