Skip to content

Commit

Permalink
Merge pull request #515 from k-okada/ros-o
Browse files Browse the repository at this point in the history
[.github/workflows/config.yml: disable installing recommends in apt-get install
  • Loading branch information
k-okada authored Dec 31, 2024
2 parents 5d4ecc6 + ed63e70 commit b2ba5a8
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,8 @@ jobs:
apt install -qq -y python3-rosdep2
echo "yaml ${{ matrix.ROS_REPOSITORY_URL }}/local.yaml debian" | tee /etc/ros/rosdep/sources.list.d/1-ros-o-builder.list
rosdep update
# disable installing recommends as ros-o-builder do
echo 'APT::Install-Recommends "false";' | tee /etc/apt/apt.conf.d/99norecommends
- name: Setup catkin-tools
run: |
Expand Down
1 change: 1 addition & 0 deletions 3rdparty/downward/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
<build_depend condition="$ROS_PYTHON_VERSION == 2">python</build_depend>
<build_depend condition="$ROS_PYTHON_VERSION == 3">python3</build_depend>
<build_depend>flex</build_depend>
<build_depend>libfl-dev</build_depend>
<build_depend>bison</build_depend>
<build_depend>gawk</build_depend>
<build_depend>rostest</build_depend>
Expand Down
4 changes: 2 additions & 2 deletions nfc_ros/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ catkin_package(
CATKIN_DEPENDS message_runtime
)

if ("$ENV{ROS_DISTRO}" MATCHES "indigo")
if ("$ENV{ROS_DISTRO}" MATCHES "indigo" OR "$ENV{ROS_DISTRO}" MATCHES "kinetic")
message(WARNING "nfc_ros requires python3.6 or newer. For indigo, virtualenv generation is skipped.")
else()
catkin_generate_virtualenv(
Expand All @@ -36,7 +36,7 @@ install(FILES requirements.txt
DESTINATION ${CATKIN_PACKAGE_SHARE_DESTINATION}
)

if(CATKIN_ENABLE_TESTING)
if(CATKIN_ENABLE_TESTING AND ("$ENV{ROS_DISTRO}" MATCHES "indigo" OR "$ENV{ROS_DISTRO}" MATCHES "kinetic"))
find_package(rostest REQUIRED)
add_rostest(test/test_rospy_node.test
DEPENDENCIES ${PROJECT_NAME}_generate_virtualenv
Expand Down

0 comments on commit b2ba5a8

Please sign in to comment.