Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spinal][Gthub Action] New workflow process for Spinal firmware CI to avoid unexpected failure in build check. #646

Merged
merged 10 commits into from
Jan 3, 2025

Conversation

sugihara-16
Copy link
Contributor

What is this

This PR provides an iterative build process for the CI of Spinal firmware.
In the previous version, generated files from the ROS package build were sometimes deleted from the GitHub action workspace. It causes build errors in some STM32 files which depend on ros packages.
Since this phenomenon is probabilistic, we can avoid it just by repeating the build process.
For detailed information on the new process, please refer to the attached log file.

logs_32558730383.zip

@tongtybj
Copy link
Collaborator

tongtybj commented Jan 2, 2025

@sugihara-16

Thank you for your valuable contribution!
I also devel into the log of GA, and figured out the reason of failure is the incorrect catkin build option.
You can check the detail and the solution from this PR: #648

On the other hand, repeat test is also very important. So I suggest you to merge #648, and then I will merge this PR.

@sugihara-16
Copy link
Contributor Author

@tongtybj
Very insightful!
Just as a formality, I merged #648 into this PR.

@tongtybj
Copy link
Collaborator

tongtybj commented Jan 3, 2025

@sugihara-16

Thank you for the merge.
Unfortunately, confilict happens after I merge #648 .
Could you solve this problem?

@sugihara-16
Copy link
Contributor Author

@tongtybj
I merged the current master and confirmed no conflict occurred. Please check!

@tongtybj tongtybj merged commit 3e9f05d into jsk-ros-pkg:master Jan 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants