Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assimp devel #387

Merged
merged 25 commits into from
Apr 16, 2014
Merged

Add assimp devel #387

merged 25 commits into from
Apr 16, 2014

Conversation

k-okada
Copy link
Member

@k-okada k-okada commented Apr 15, 2014

move assimp_devel from jsk_model_tools,

  • do not use .pc and cmake generated from catkin
  • only use original .pc
  • name of library and include has changed from assimp to assimp_devel, to avoid confusion.

originally discussed here -> jsk-ros-pkg/jsk_model_tools#20

@YoheiKakiuchi
Copy link
Member

Why this package provide only original .pc ?

@k-okada
Copy link
Member Author

k-okada commented Apr 16, 2014

To avoid confusion.
also in the feature, Debian official package will be updated and assimp_devel is no longer needed, at that time, we have to use .ps anyway.

YoheiKakiuchi added a commit that referenced this pull request Apr 16, 2014
@YoheiKakiuchi YoheiKakiuchi merged commit c254437 into jsk-ros-pkg:master Apr 16, 2014
@k-okada k-okada deleted the add_assimp_devel branch April 16, 2014 14:49
@k-okada
Copy link
Member Author

k-okada commented Apr 16, 2014

thank you. please remove assimp_devel from jsk_model_tools and check #386

@k-okada
Copy link
Member Author

k-okada commented Apr 17, 2014

previous comment was wrong, see #394

k-okada added a commit that referenced this pull request Apr 17, 2014
k-okada added a commit to jsk-ros-pkg/jsk_common_msgs that referenced this pull request Jun 12, 2015
k-okada added a commit to jsk-ros-pkg/jsk_3rdparty that referenced this pull request Jun 12, 2015
k-okada added a commit to jsk-ros-pkg/jsk_3rdparty that referenced this pull request Jun 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants