Merge pull request #884 from k-okada/add_pyyaml_test

face_detector is released, so remove .travis.rosinstall.noetic . add test to check with latest pyyaml from pip
jsk-ros-pkg · Jan 20, 2024 · 8bb999d · 8bb999d
2 parents 29fac6c + 1a98ce8
commit 8bb999d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/.github/workflows/config.yml b/.github/workflows/config.yml
@@ -26,7 +26,9 @@ jobs:
             CONTAINER: ubuntu:18.04
           - ROS_DISTRO: noetic
             CONTAINER: ubuntu:20.04
-            USE_DEB : false # to use .travis.rosinstall.noetic for face_detector
+          - ROS_DISTRO: noetic
+            CONTAINER: ubuntu:20.04
+            BEFORE_SCRIPT: "pip3 install -U --user pyyaml"
 
     container: ${{ matrix.CONTAINER }}
     steps:

diff --git a/.travis.rosinstall.noetic b/.travis.rosinstall.noetic
diff --git a/jsk_rqt_plugins/src/jsk_rqt_plugins/tabbed_button_general.py b/jsk_rqt_plugins/src/jsk_rqt_plugins/tabbed_button_general.py
@@ -162,7 +162,7 @@ def __init__(self, settings):
             resolved_yaml = resolved_yaml[len("file://"):]
 
         with open(resolved_yaml) as f:
-            yaml_data = yaml.load(f)
+            yaml_data = yaml.safe_load(f)
             self.setupButtons_with_yaml_data(yaml_data=yaml_data, namespace=namespace)
 
         self.show()