Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(transloco-util): add keysManager.sort key to TranslocoGlobalConfig #826

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xDivisionByZerox
Copy link

@xDivisionByZerox xDivisionByZerox commented Jan 9, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe: Types

What is the current behavior?

No property keysManager.sort in the TranslocoGlobalConfig interface.

Issue Number: #825

What is the new behavior?

Expose property keysManager.sort for TranslocoGlobalConfig publically.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

I'm not sure if there should be a documentation change for the page hosted under https://jsverse.gitbook.io/transloco/tools/keys-manager-tkm/options#transloco-config-file. I would apprechiate some input for this question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant