fixes erroneous use of == in PricePlot (issue #1237)
#1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
reviewed
Oct 18, 2023
benmccann
approved these changes
Oct 18, 2023
|
thanks for the review @benmccann hawk eye! I had to rename the file too as it broke the build (class name != filename). I renamed also the test name. |
ccleva
pushed a commit
to tlabs-data/tablesaw
that referenced
this pull request
Nov 19, 2024
ccleva
added a commit
to tlabs-data/tablesaw
that referenced
this pull request
Nov 19, 2024
…lesaw#1238) (#16) * fixes erroneous use of `==` in PricePlot (issue jtablesaw#1237) (jtablesaw#1238) * Port back test to java 8 * Upgrade maven compiler plugin and add release tag * Added test cases with Instant and LocalDate * Code cleanup --------- Co-authored-by: Francesco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing.
Description
What was changed
Fixes erroneous use of
==in PricePlot (issue #1237)Testing
Did you add a unit test?
Yes