New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid read(URL) throwing NPE for invalid URLs #1272

Merged

benmccann merged 6 commits into jtablesaw:master from tlabs-data:fix_NPE_in_read_with_invalid_url

Jan 3, 2025

Contributor

ccleva commented Jan 3, 2025

Thanks for contributing.

Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1

Description

If DataFrameReader.read(URL) is called with an invalid URL a NPE is thrown. Code refactored to throw either RuntimeIOException (when the URL has a known file extension) or IllegalArgumentException if not.

Testing

Yes


          Avoid read(URL) throwing NPE for invalid URLs

020e8d8

ccleva mentioned this pull request

Is there any plan to release a new version since the lasted version had past two years #1251

Open

benmccann reviewed

View reviewed changes

core/src/main/java/tech/tablesaw/io/DataFrameReader.java Outdated Show resolved Hide resolved

benmccann reviewed

View reviewed changes

core/src/main/java/tech/tablesaw/io/DataFrameReader.java Outdated Show resolved Hide resolved

benmccann reviewed

View reviewed changes

core/src/main/java/tech/tablesaw/io/DataFrameReader.java Outdated Show resolved Hide resolved

benmccann reviewed

View reviewed changes

core/src/test/java/tech/tablesaw/io/DataFrameReaderTest.java Outdated Show resolved Hide resolved

benmccann reviewed

View reviewed changes

core/src/test/java/tech/tablesaw/io/DataFrameReaderTest.java Outdated Show resolved Hide resolved

ccleva and others added 5 commits

January 3, 2025 15:56


          Update core/src/main/java/tech/tablesaw/io/DataFrameReader.java

7be3bff

Co-authored-by: Ben McCann <[email protected]>


          Update core/src/main/java/tech/tablesaw/io/DataFrameReader.java

5d57aa7

Co-authored-by: Ben McCann <[email protected]>


          Update core/src/main/java/tech/tablesaw/io/DataFrameReader.java

b2c3482

Co-authored-by: Ben McCann <[email protected]>


          Update core/src/test/java/tech/tablesaw/io/DataFrameReaderTest.java

c315b81

Co-authored-by: Ben McCann <[email protected]>


          Update core/src/test/java/tech/tablesaw/io/DataFrameReaderTest.java

36a4bca

Co-authored-by: Ben McCann <[email protected]>

benmccann merged commit 0dca618 into jtablesaw:master

7 checks passed

ccleva deleted the fix_NPE_in_read_with_invalid_url branch

January 3, 2025 17:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet