fix readahead bug then trying to turn off readahead totally #5547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you elaborate the bug? Setting |
|
yes, it's true, but if you set 0, the behavior is unexpected, I expected it to be 0 and not block_size * 8. in fact, in general, this is a useless parameter in the end, since in the end, the entire block is going through the network anyway in asynchronous mode for caches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you try to turn off readahead, you still get traffic you don't expect.
in this fix we limit readaheadMax to zero in case any readahead is turned off.
The question remains what is the expected behavior in the case of the max-readahead==0 parameter