Set service_user_id from keystone relation #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary so we can avoid ambiguities (by using the id vs name) when we want to use the service user.
ajkavanagh
approved these changes
Jan 15, 2024
openstack-mirroring
pushed a commit
to openstack/charm-cinder
that referenced
this pull request
Feb 26, 2024
admin_tenant_id and admin_user_id are more explicit than admin_tenant_name and admin_user as names could duplicate and cause issues. Includes sync from Charm-helpers PR #874 below Charm-helpers-pr: juju/charm-helpers#874 Closes-Bug: #2030755 Change-Id: Idbc2f3d12dcf325b4a53a3dda1ecfa75a199295a
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Feb 26, 2024
* Update charm-cinder from branch 'master'
to 26cc4b30b58abe3a8f53616745e3154993ef3b2b
- Merge "Use ids for cinder internal tenant and user"
- Use ids for cinder internal tenant and user
admin_tenant_id and admin_user_id are more explicit than
admin_tenant_name and admin_user as names could duplicate
and cause issues.
Includes sync from Charm-helpers PR #874 below
Charm-helpers-pr: juju/charm-helpers#874
Closes-Bug: #2030755
Change-Id: Idbc2f3d12dcf325b4a53a3dda1ecfa75a199295a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary so we can avoid ambiguities (by using the id vs name) when we want to use the service user.