Skip to content

Commit

Permalink
fix: use charmcraft 2.x to build
Browse files Browse the repository at this point in the history
Version 3 of charmcraft does not allow a run-on stanza that includes
24.04 with other versions, but 2 does. So we install this versions for
   our Github workflows.
  • Loading branch information
manadart committed Nov 8, 2024
1 parent e5b9963 commit 55fc19d
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ jobs:
needs: unit-tests
uses: canonical/data-platform-workflows/.github/workflows/build_charms_with_cache.yaml@v4
with:
charmcraft-snap-channel: 2.x/stable
artifact-name: charm-packed


Expand Down Expand Up @@ -93,7 +94,7 @@ jobs:
env:
CHARMCRAFT_AUTH: ${{ secrets.CHARMCRAFT_AUTH }}
run: |
sudo snap install charmcraft --classic
sudo snap install charmcraft --channel 2.x/stable --classic
charmcraft upload ${{ steps.download.outputs.download-path }}/*.charm \
--name $CHARM_NAME \
--release ${{ needs.channel.outputs.test }}
Expand Down Expand Up @@ -143,7 +144,7 @@ jobs:

- name: Install Juju
run: |
sudo snap install juju --channel 3.3/beta
sudo snap install juju --channel 3.5/stable
- name: Bootstrap on LXD
if: matrix.cloud == 'lxd'
Expand Down Expand Up @@ -179,7 +180,7 @@ jobs:
steps:
- name: Install Charmcraft
run: |
sudo snap install charmcraft --classic
sudo snap install charmcraft --channel 2.x/stable --classic
- name: Get uploaded revision
id: revision
Expand Down

0 comments on commit 55fc19d

Please sign in to comment.