Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set_leader in test_website_relation_joined #40

Merged
merged 1 commit into from
Oct 17, 2023
Merged

set_leader in test_website_relation_joined #40

merged 1 commit into from
Oct 17, 2023

Conversation

barrettj12
Copy link
Contributor

The test_website_relation_joined unit test was failing because I forgot to update the test in #14. The _on_website_relation_joined handler only adds the relation data if it's the leader unit.

The fix is easy - call harness.set_leader() before adding the relation.

QA steps

virtualenv -p python3 venv
source venv/bin/activate
pip install -r requirements-dev.txt
./run_tests

@barrettj12 barrettj12 merged commit 4e2dee9 into juju:3.1 Oct 17, 2023
4 of 5 checks passed
@barrettj12 barrettj12 deleted the test-set-leader branch October 17, 2023 07:37
This was referenced Oct 17, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyworld wallyworld wallyworld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barrettj12 @wallyworld