Update event schema version type (#421)

* Update event schema version type * Tweak maxDiffPixelRatio * Set maxDiffPixelRatio to 0.001 Co-authored-by: Duc Trung Le <[email protected]> * Set maxDiffPixelRatio to 0.01 --------- Co-authored-by: Duc Trung Le <[email protected]>
jupyterlab · Dec 18, 2024 · 0a75715 · 0a75715
1 parent dcce8f5
commit 0a75715
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 4 deletions.
diff --git a/projects/jupyter-server-ydoc/jupyter_server_ydoc/events/awareness.yaml b/projects/jupyter-server-ydoc/jupyter_server_ydoc/events/awareness.yaml
@@ -1,6 +1,6 @@
 "$id": https://schema.jupyter.org/jupyter_collaboration/awareness/v1
 "$schema": "http://json-schema.org/draft-07/schema"
-version: 1
+version: "1"
 title: Collaborative awareness events
 personal-data: true
 description: |

diff --git a/projects/jupyter-server-ydoc/jupyter_server_ydoc/events/fork.yaml b/projects/jupyter-server-ydoc/jupyter_server_ydoc/events/fork.yaml
@@ -1,6 +1,6 @@
 "$id": https://schema.jupyter.org/jupyter_collaboration/fork/v1
 "$schema": "http://json-schema.org/draft-07/schema"
-version: 1
+version: "1"
 title: Collaborative fork events
 personal-data: true
 description: |

diff --git a/projects/jupyter-server-ydoc/jupyter_server_ydoc/events/session.yaml b/projects/jupyter-server-ydoc/jupyter_server_ydoc/events/session.yaml
@@ -1,6 +1,6 @@
 "$id": https://schema.jupyter.org/jupyter_collaboration/session/v1
 "$schema": "http://json-schema.org/draft-07/schema"
-version: 1
+version: "1"
 title: Collaborative session events
 personal-data: true
 description: |

diff --git a/pyproject.toml b/pyproject.toml
@@ -106,6 +106,8 @@ filterwarnings = [
     'ignore:Unclosed <MemoryObjectSendStream:ResourceWarning',
     # see https://github.com/python/cpython/issues/126259
     'ignore:unclosed database in <sqlite3.Connection object',
+    # remove when this is merged: https://github.com/jupyter-server/jupyter_server/pull/1481
+    'ignore:The `version` property of an event schema must be a string'
 ]
 
 [tool.mypy]

diff --git a/ui-tests/playwright.config.js b/ui-tests/playwright.config.js
@@ -20,7 +20,7 @@ module.exports = {
   },
   expect: {
     toMatchSnapshot: {
-      maxDiffPixelRatio: 0.0001
+      maxDiffPixelRatio: 0.01
     }
   }
 };