Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(elasticsearch): Fixed permission to add to directories in elasticsearch plugins #332

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

secobarbital
Copy link
Contributor

We need to add the write permission to directories in elasticsearch plugins, not execute, which they already have.

Sorry @shivaraj-bh this was a typo in my suggestion in #331

@secobarbital secobarbital changed the title Fixed permission to add to directories in elasticsearch plugins fix(elasticsearch): Fixed permission to add to directories in elasticsearch plugins Sep 21, 2024
@shivaraj-bh
Copy link
Member

Does the test need some fixing as well? I just assumed it was all good because the test passed.

@secobarbital
Copy link
Contributor Author

Hmm… that makes sense. The problem arises on the next time you start it, when the startup script tries to delete the plugins directory, so the test would have to start it twice.

@shivaraj-bh
Copy link
Member

The problem arises on the next time you start it, when the startup script tries to delete the plugins directory, so the test would have to start it twice.

This will need some discussion in the upstream process-compose-flake.

For now, I have tested this PR, we can go ahead with the merge.

@shivaraj-bh shivaraj-bh merged commit 67f91ab into juspay:main Sep 23, 2024
2 checks passed
@shivaraj-bh
Copy link
Member

This will need some discussion in the upstream process-compose-flake.

Platonic-Systems/process-compose-flake#78

@secobarbital
Copy link
Contributor Author

Thank you!

@secobarbital secobarbital deleted the elasticsearch-plugins-write branch September 24, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants