Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nats-server): Add service #425

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

misuzu
Copy link
Contributor

@misuzu misuzu commented Jan 3, 2025

@misuzu misuzu force-pushed the nats-server branch 2 times, most recently from a56ed19 to 98245fa Compare January 3, 2025 16:49
@shivaraj-bh
Copy link
Member

98245fa nice! I was just about to mention the healthz endpoint

nix/services/nats-server.nix Show resolved Hide resolved
nix/services/nats-server_test.nix Outdated Show resolved Hide resolved
@shivaraj-bh
Copy link
Member

shivaraj-bh commented Jan 3, 2025

One last thing, can you format with pre-commit run -a? I am yet to document it, but this is due to removing treefmt.

CI passes formatting checks due to #238

Edit: #238 is now fixed

@shivaraj-bh
Copy link
Member

shivaraj-bh commented Jan 3, 2025

Also, if you are not using the devShell here’s a one-liner that you can use from the project root: nix develop ./dev --command bash -c "pre-commit run -a"

@shivaraj-bh shivaraj-bh merged commit 8a2bb69 into juspay:main Jan 3, 2025
2 checks passed
@misuzu
Copy link
Contributor Author

misuzu commented Jan 3, 2025

Thanks!

@misuzu misuzu deleted the nats-server branch January 3, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants