Ability to fetch track artwork as Base 64

[dylanvorster]

Hi There

I really liked your library and how easy it was to use. I needed the ability to also fetch the artwork from iTunes for the application I'm building, and so I implemented an option where you can say : ({fetchArtwork: true}) and it will add the artwork to the transport. It gets encoded as a base64 and I've tested that it works on mac. I haven't yet added the support to windows, but ill probably get to that in a few weeks.

Cheers

[jwalgran]

Thanks for the PR. I am away from the computer for a few days, but I'll be able to review this soon.

On Aug 2, 2015, at 1:39 PM, dylanvorster [email protected] wrote:

Hi There

I really liked your library and the how easy it was to use. I needed the ability to also fetch the artwork from iTunes for the application I'm building, and so I implemented an option where you can say : ({fetchArtwork: true}) and it will add the artwork to the transport. It gets encoded as a base64 and I've tested that it works on mac. I haven't yet added the support to windows, but ill probably get to that in a few weeks.

Cheers

You can view, comment on, or merge this pull request online at:

#4

Commit Summary

Added support for optionally fetching artwork as base64
Added docs, and small hotfi
Added docs, and small hotfix
Merge branch 'master' of https://github.com/dylanvorster/playback
fix demo
File Changes

M .gitignore (91)
D applescripts/ApplicationLib.applescript (4)
D applescripts/ApplicationLib.scpt (0)
M applescripts/ITunesTransport.applescript (230)
M applescripts/ITunesTransport.scpt (0)
M demo.js (4)
M index.js (43)
M package.json (25)
M readme.md (10)
Patch Links:

https://github.com/jwalgran/playback/pull/4.patch
https://github.com/jwalgran/playback/pull/4.diff
—
Reply to this email directly or view it on GitHub.

[FlorianWendelborn]

@dylanvorster somewhat unrelated, but if you have access to a mac you could probably add the setVolume method for mac too. Should be an easy one. I added it for windows already, but can't test on OSX.

[jwalgran]

I tested this and it works well. I would like to clean up the package.json a little before merging it.

[jwalgran]

Based on looking at the package.json for a lot of other popular modules, I would like to remove the following keys from the commit:

_id
dist
_from
_npmVersion
_npmUser
_shasum
_resolved
directories (because it just refers to an empty object)

[dylanvorster]

Cool beans :) Ive realised that there might be an issue if there is no artwork, my entire iTunes library all has artwork (which is why Im not sure if this is an issue) so we probably just need to look at it.