Introduce new env var LTP_JAR_DIR_PATH to let the user specify a custom installation path of LT
#86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jxmorris12 I fixed some typos, the CI should run fine now. |
|
thanks -- this is really helpful :) |
ybracke
pushed a commit
to ybracke/transnormer-data
that referenced
this pull request
Apr 18, 2024
Background: Some rules and many RuleIDs changed between v6.3 and v6.4 and my personal rule list is currently based on v6.3. Thus, in general, we could make the LT version flexible. This now possible in language_tool_python, see PR [#82](jxmorris12/language_tool_python#86). Note that, because of a mistake in the language_tool_python code, the program will print "Downloading LanguageTool 6.4", regardless of the version that is specified via LanguageTool(language_tool_download_version).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84
Fixes #82
At the moment,
language_tool_pythonwill download a fixed version of LanguageTool (LT).There was also a inconsistency in the code when a more recent version of LT is installed in the download path:
Now the user can specify the
LTP_JAR_DIR_PATHenvironment variable.If this variable is defined, the package will look for the LanguageTool jar files in this folder.
Otherwise it will download LanguageTool is the download folder.
The user can also change the LanguageTool version that is downloaded:
I also took the liberty to fix some formatting.
Note that in the tests
tests/test_local.bash, the sentence 'These are "dumb" quotes.' is now accepted by the 6.4 version of the LanguageTool.Using the 6.4 version, I also got a different ordering of the suggestions, so I only check the set and I am flexible on the order.