Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with go v1.22 #566

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

zeeke
Copy link
Member

@zeeke zeeke commented Jun 7, 2024

Updating the build to go v1.22 is a requirement
for bumping to k8s.io/[email protected]

needed for:

@coveralls
Copy link
Collaborator

coveralls commented Jun 7, 2024

Pull Request Test Coverage Report for Build 9416425178

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.187%

Totals Coverage Status
Change from base Build 9348201769: 0.0%
Covered Lines: 2115
Relevant Lines: 2813

💛 - Coveralls

@SchSeba
Copy link
Collaborator

SchSeba commented Jun 12, 2024

Hi @zeeke please bump also in the go.mod file

Updating the build to go v1.22 is a requirement
for bumping to `k8s.io/[email protected]`

Refs
- k8snetworkplumbingwg#562

Signed-off-by: Andrea Panattoni <[email protected]>
@coveralls
Copy link
Collaborator

coveralls commented Jun 13, 2024

Pull Request Test Coverage Report for Build 9498812654

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.187%

Totals Coverage Status
Change from base Build 9348201769: 0.0%
Covered Lines: 2115
Relevant Lines: 2813

💛 - Coveralls

Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrianchiris adrianchiris merged commit fe9f2f8 into k8snetworkplumbingwg:master Jun 19, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants