Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Yii formatted URL #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

cornernote
Copy link

also slight changes in widgets/JsTreeWidget.php:

  • rename Yii_js.csrf to JsTreeBehavior.csrfToken
  • remove Yii_js (its empty now)
  • use json_encode() to format the entire JsTreeBehavior array
  • only call Yii::app()->clientScript once, then assign to variable

fixes issue #7

@kabasakalis
Copy link
Owner

Your extension is great,and I am happy you used and adapted my extension for your needs.I also use it for menu management in my CMS.I appreciate your contribution,the problem is I cannot merge without testing this all.If something breaks I will have tenths of issues in Github complaining.And frankly,I have no time to test this.I am also focusing on Yii2 right now,I don't want to invest time in Yii1 extensions.And since there's no bug ,just an enhancement,I'd better leave my extension as is.I hope you understand.Great job!

@cornernote
Copy link
Author

Yes I understand. The issue is fixed for all purposes I require, so if we can just leave this pull request open for anyone else who encounters the problem that should be enough.

@kabasakalis
Copy link
Owner

Sure,I'll leave it open!Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants