Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API, CLI: Add feature to rebalance (migrate-data) #290

Merged
merged 4 commits into from
Jan 17, 2023
Merged

API, CLI: Add feature to rebalance (migrate-data) #290

merged 4 commits into from
Jan 17, 2023

Conversation

vatsa287
Copy link
Member

@vatsa287 vatsa287 commented Jan 9, 2023 •
edited
Loading

  • Add support for volume rebalance with subcommand kadalu rebalance start/stop
  • Fix issue of re-expanding brick by removing status file correspoding expanded storage-unit-path.
  • Reuse 'manage_services` node_action for migrate_data start/stop with new-argument.
  • Add tests to check for rebalance(fix-layout + migrate-data) of files.

Fixes: #289
Updates: kadalu/rfcs#26
Signed-off-by: Shree Vatsa N [email protected]

@vatsa287 vatsa287 marked this pull request as draft January 9, 2023 08:12
@vatsa287 vatsa287 force-pushed the migrate-data branch 3 times, most recently from 7066dcb to 6d74a8b Compare January 9, 2023 08:18
aravindavk
aravindavk reviewed Jan 9, 2023
View reviewed changes
mgr/src/cmds/volumes.cr Outdated Show resolved Hide resolved
aravindavk
aravindavk reviewed Jan 9, 2023
View reviewed changes
mgr/src/server/services/fix_layout.cr Outdated Show resolved Hide resolved
mgr/src/server/services/migrate_data.cr Outdated Show resolved Hide resolved
@vatsa287 vatsa287 force-pushed the migrate-data branch 2 times, most recently from d806d8b to 42e762b Compare January 16, 2023 06:41
@vatsa287 vatsa287 force-pushed the migrate-data branch 6 times, most recently from a9c383d to 1d557d8 Compare January 17, 2023 06:54
@vatsa287
Add tests
26e40b8 
Signed-off-by: Shree Vatsa N <[email protected]>
@vatsa287 vatsa287 force-pushed the migrate-data branch 2 times, most recently from 079bc7e to 8019344 Compare January 17, 2023 08:42
@vatsa287
Address review comments 1
f1ac911 
Signed-off-by: Shree Vatsa N <[email protected]>
@vatsa287 vatsa287 marked this pull request as ready for review January 17, 2023 09:06
@vatsa287
Copy link
Member Author

@aravindavk @amarts ^^

@aravindavk aravindavk merged commit 40422c8 into kadalu:main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aravindavk aravindavk aravindavk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Rebalance status file before start
2 participants
@vatsa287 @aravindavk