Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add core data modules #17

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Add core data modules #17

merged 5 commits into from
Jan 17, 2024

Conversation

ioangatop
Copy link
Collaborator

Closes #16

@ioangatop ioangatop self-assigned this Jan 17, 2024
@ioangatop ioangatop linked an issue Jan 17, 2024 that may be closed by this pull request
Add the core data modules #16
Closed
@ioangatop
Copy link
Collaborator Author

@nkaenzig @roman807 this turned out to be a quite big enough PR, please let me know if should I break it into smaller ones (maybe into 3 different ones; dataset, dataloader and datamodule)

nkaenzig
nkaenzig approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@nkaenzig nkaenzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ioangatop ioangatop merged commit 14f95ce into main Jan 17, 2024
1 check passed
@ioangatop ioangatop deleted the 16-add-the-core-data-modules branch January 17, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-abderrahmane b-abderrahmane b-abderrahmane left review comments

@nkaenzig nkaenzig nkaenzig approved these changes

@roman807 roman807 Awaiting requested review from roman807

Assignees

@ioangatop ioangatop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the core data modules
3 participants
@ioangatop @b-abderrahmane @nkaenzig