Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: D: Fixup usage of Cobra APIs in preparation for command line testing. #3326

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

aaron-kasten
Copy link
Contributor

Change Overview

This PR fixes the command line endpoints to use Cobra supplied tools for assigning context and outputs. Using Cobra APIs will support command-line unit tests to be added later.

Pull request type

Please check the type of change your PR introduces:

  • 🌻 Feature

Issues

There is no GitHub issue associated with this PR.

Test Plan

To support unit tests.

  • ⚡ Unit test

@aaron-kasten aaron-kasten changed the title Fixup usage of Cobra APIs in preparation for command line testing. test: Fixup usage of Cobra APIs in preparation for command line testing. Jan 14, 2025
@aaron-kasten aaron-kasten changed the title test: Fixup usage of Cobra APIs in preparation for command line testing. test: D: Fixup usage of Cobra APIs in preparation for command line testing. Jan 14, 2025
Signed-off-by: Aaron Alpar <[email protected]>
Signed-off-by: Aaron Alpar <[email protected]>
Signed-off-by: Aaron Alpar <[email protected]>
Copy link
Contributor

@tdmanv tdmanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didn't know about OutOrStdout() - very cool!

@mergify mergify bot merged commit 9dd5e00 into kanisterio:master Jan 14, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants