Fix NewClient()

que.go

@@ -211,10 +211,8 @@ type Client struct {
 	// TODO: add a way to specify default queueing options
 }
 
-// NewClient2 creates a new Client that uses the pgx pool.
-//
-// Deprecated: Use `NewClient` instead.
-func NewClient2(pool *sql.DB) (*Client, error) {
+// NewClient creates a new Client that uses the pgx pool.
+func NewClient(pool *sql.DB) (*Client, error) {
 	stmtJobStats, err := pool.Prepare(sqlJobStats)
 	if err != nil {
 		return nil, err
@@ -226,11 +224,11 @@ func NewClient2(pool *sql.DB) (*Client, error) {
 	}, nil
 }
 
-// NewClient creates a new Client that uses the pgx pool. Returns nil if the initialization fails.
-func NewClient(pool *sql.DB) *Client {
-	c, err := NewClient2(pool)
+// MustNewClient creates a new Client that uses the pgx pool. Panic if the initialization fails.
+func MustNewClient(pool *sql.DB) *Client {
+	c, err := NewClient(pool)
 	if err != nil {
-		return nil
+		panic(err)
 	}
 	return c
 }

que_test.go

@@ -30,7 +30,7 @@ func openTestClientMaxConns(t testing.TB, maxConnections int) *Client {
 	db.SetMaxIdleConns(maxConnections)
 	// make lifetime sufficiently long
 	db.SetConnMaxLifetime(time.Duration(5 * time.Minute))
-	c, err := NewClient2(db)
+	c, err := NewClient(db)
 	if err != nil {
 		t.Fatal(err)
 	}