Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: index 1.7.1 #4178

Merged
merged 1 commit into from
Oct 26, 2023
Merged

helm: index 1.7.1 #4178

merged 1 commit into from
Oct 26, 2023

Conversation

a7i
Copy link
Contributor

@a7i a7i commented Oct 25, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:
publishes 1.7.1 helm release

I am able to pull 1.7.1


Error: accumulating resources: accumulation err='accumulating resources from '../base/': '/Users/amir.alavi/workspace/k8s-clusterset/kustomize/base' must resolve to a file': recursed accumulation of path '/Users/amir.alavi/workspace/k8s-clusterset/kustomize/base': Error: chart "karmada" version "v1.7.1" not found in https://raw.githubusercontent.com/karmada-io/karmada/master/charts repository
: unable to run: ...

Which issue(s) this PR fixes:
Follow up to https://github.com/karmada-io/karmada/releases/tag/v1.7.1

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`Helm chart`: Added helm index for 1.7.1 release.

Signed-off-by: Amir Alavi <[email protected]>
@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 25, 2023
@karmada-bot karmada-bot requested review from jrkeen and Poor12 October 25, 2023 21:02
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 25, 2023
@@ -1,6 +1,28 @@
apiVersion: v1
entries:
karmada:
- apiVersion: v2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

steps to sync this:

wget https://github.com/karmada-io/karmada/releases/download/v1.7.1/karmada-chart-v1.7.1.tgz -O charts/karmada/charts/karmada-chart-v1.7.1.tgz
 
helm repo index charts/karmada --url https://github.com/karmada-io/karmada/releases/download --merge charts/index.yaml
 
mv charts/karmada/index.yaml charts/index.yaml 
  • manual steps:
  1. change appVersion from latest to v1.1.0
  2. change theurls from https://github.com/karmada-io/karmada/releases/download/charts/karmada-chart-v1.7.0.tgz to https://github.com/karmada-io/karmada/releases/download/v1.7.1/karmada-chart-v1.7.1.tgz

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f57e362) 52.91% compared to head (91c238d) 52.95%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4178      +/-   ##
==========================================
+ Coverage   52.91%   52.95%   +0.03%     
==========================================
  Files         239      239              
  Lines       23522    23522              
==========================================
+ Hits        12447    12455       +8     
+ Misses      10399    10392       -7     
+ Partials      676      675       -1     
Flag Coverage Δ
unittests 52.95% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chaosi-zju
Copy link
Member

thanks for your quick fix

LGTM

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2023
@karmada-bot karmada-bot merged commit e8b1720 into karmada-io:master Oct 26, 2023
12 checks passed
@a7i a7i deleted the amir/index-1.7.1 branch October 26, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants